Skip to content

chore: fix tests setup #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

chore: fix tests setup #149

merged 1 commit into from
Jun 23, 2025

Conversation

gg-jonathangriffe
Copy link
Contributor

@gg-jonathangriffe gg-jonathangriffe commented Jun 23, 2025

Fix tests setup.
Two issues made the test experience worse :

  • The error message for the setup check for enough people in the workspace indicated the wrong amount of members. Having a lower number made a test fail.
  • One member was deleted by the test. This is annoying since we can only create membership by creating invitations and manually getting the link in the invitation email. Creating a membership for oneself is simple since one can get the mail, but having to ask someone else to click the link is less simple. This MR mitigates this by allowing to set the membership that will be deleted in a GG_EMAIL env var.

@gg-jonathangriffe gg-jonathangriffe self-assigned this Jun 23, 2025
@gg-jonathangriffe gg-jonathangriffe requested a review from a team as a code owner June 23, 2025 13:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (0c9c96d) to head (51c8353).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files           5        5           
  Lines        1208     1208           
=======================================
  Hits         1157     1157           
  Misses         51       51           
Flag Coverage Δ
unittests 95.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gg-jonathangriffe gg-jonathangriffe added the skip-changelog No changelog check in the CI label Jun 23, 2025
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments, but I like the approach: it's going to make py-gitguardian release less painful 👍🏻.

salome-voltz

This comment was marked as duplicate.

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gg-jonathangriffe gg-jonathangriffe merged commit 233f8b2 into master Jun 23, 2025
19 checks passed
@gg-jonathangriffe gg-jonathangriffe deleted the jgriffe/fix-tests branch June 23, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog check in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants